Re: [PATCH v2] Cache the expanded prompt for editline

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Thu, Jan 14, 2021 at 10:43:21AM -0500, June Bug wrote:
> 
> It seems unlikely given the lack of consistency of when libedit
> calls the prompt callback. I only noticed it was happening when I
> patched in support for EL_RPROMPT (right-aligned prompts), which
> when active causes libedit to call the prompt callback on *every*
> keypress. It seemed not to happen with only a regular prompt and
> it took some experimenting to notice typing backspaces causes it.
> The behaviour is completely undocumented in libedit.
> 
> Anecdotally, typing at the prompt becomes painful when it is expanded
> over and over and does anything non-trivial, even just a command
> substitution that runs no external commands.

OK, in that case I think it's best to fix this in libedit instead.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt