Re: [PATCH] Don't include config.h when building helpers using the native compiler

[Fabrice Fontaine <fontaine.fabrice@xxxxxxxxx>]

Dear all,

Le lun. 22 juin 2020 à 10:53, Harald van Dijk <harald@xxxxxxxxxxx> a écrit :
>
> On 22/06/2020 06:25, Fabrice Fontaine wrote:
> > config.h contains settings for the cross compiler (most importantly
> > 32/64bit versions of functions), so don't include it when calling the
> > native compiler to build the helpers.
> >
> > Otherwise we get build errors like:
> >
> > /usr/bin/gcc -include ../config.h -DBSD=1 -DSHELL -DIFS_BROKEN  -g -O2 -Wall    -o mkinit mkinit.c
> > In file included from /usr/include/sys/stat.h:107,
> >                   from /usr/include/fcntl.h:38,
> >                   from mkinit.c:50:
> > /usr/include/bits/stat.h:117: error: redefinition of ‘struct stat’
> > In file included from /usr/include/fcntl.h:38,
> >                   from mkinit.c:50:
> > /usr/include/sys/stat.h:504: error: redefinition of ‘stat’
> > /usr/include/sys/stat.h:455: note: previous definition of ‘stat’ was here
> >
> > Signed-off-by: Peter Korsgaard <jacmet@xxxxxxxxxx>
> > [Retrieved from:
> > https://git.buildroot.net/buildroot/tree/package/dash/0001-no-config.h-for-helpers.patch]
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@xxxxxxxxx>
>
> A better version of this patch has already been submitted and accepted
> in 2018: <https://www.spinics.net/lists/dash/msg01629.html>.
Thanks and sorry for the noise, I'll then remove this patch from my
buildroot as we have just bumped to 0.5.11.
>
> Cheers,
> Harald van Dijk
Best Regards,

Fabrice