Re: [PATCH] parser: Catch errors in expandstr

[Simon Ser <contact@xxxxxxxxxxx>]

On Tuesday, January 21, 2020 7:39 AM, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, Dec 13, 2019 at 02:51:34PM +0000, Simon Ser wrote:
>
> > Just noticed another dash bug: when setting invalid PS1 values dash
> > enters an infinite loop.
> > For instance, setting PS1='$(' makes dash print many of these:
> > dash: 1: Syntax error: end of file unexpected (expecting ")")
> > It would be nice to fallback to the default PS1 value on error.
>
> This patch fixes it by using the literal value of PS1 should an
> error occur during expansion.
>
> Reported-by: Simon Ser <contact@xxxxxxxxxxx>
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Thanks, works!

Tested-by: Simon Ser <contact@xxxxxxxxxxx>