Re: [v2 PATCH] system: Disable glibc warning on sigsetmask

[Antonio Ospite <ao2@xxxxxx>]

On Wed, 21 Nov 2018 11:37:05 +0100
Antonio Ospite <ao2@xxxxxx> wrote:

> On Wed, 21 Nov 2018 11:45:04 +0800
> Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> 
[...]
> > ---8<---
> > As sigsetmask is set as deprecated in glibc this patch adds the
> > pragmas to disable the warning in gcc around our one and only use
> > of sigsetmask.
> >
> > It also disables it completely for non-gcc compilers and older
> > gcc compilers as they may generate a warning too.
> >
> 
[...]
> Also a brief note in the commit message about _why_ sigsetmask() is
> kept around when using gcc would be useful IMHO.
> 

Hi,

I see that this has been applied as well, along with the other patches,
so gcc builds without warnings now, which is great, thank you.

I am still a bit curious about why you decided to keep sigsetmask()
around at all, tho, if you had a minute to explain your decision I
would be interested.

Ciao,
    Antonio

-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?