Re: [PATCH 0/5] Build system updates and gcc warnings fixes

[Antonio Ospite <ao2@xxxxxx>]

On Sat, 27 Oct 2018 15:35:11 +0200
Antonio Ospite <ao2@xxxxxx> wrote:

> On Tue, 16 Oct 2018 18:42:15 +0200
> Antonio Ospite <ao2@xxxxxx> wrote:
> 
> > Hi,
> > 
> > here are some build system updates and some fixes for compilation
> > warnings with Gcc.
> > 
> > After this patchset, compilation with Gcc is nice and clean,
> > 
> [...]
> >  .gitignore      |  2 ++
> >  configure.ac    |  8 +++++---
> >  src/Makefile.am | 16 ++++++++--------
> >  src/eval.c      |  2 +-
> >  src/system.h    |  4 ----
> >  5 files changed, 16 insertions(+), 16 deletions(-)
> > 
> 
> Looking at the mailing list I see there are some patches sent
> before this series which touch .gitignore and src/Makefile.am
>

I see that some of those other patches have been merged, and in fact
patch 3/5 in this series can now be skipped.

BTW a new warning was introduced by commit 8e43729 (eval: Report I/O
error on stdout, 2018-09-07):

  CC       eval.o
eval.c: In function ‘evalbltin’:
eval.c:956:3: warning: implicit declaration of function ‘warnx’; did you mean ‘sh_warnx’? [-Wimplicit-function-declaration]
   warnx("%s: I/O error", commandname);
   ^~~~~
   sh_warnx

> If you apply those first, let me know if you want me to rebase and
> resend this series to minimize conflicts.
> 

Ciao,
   Antonio

-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?