Re: [PATCH] Revert 78a00a7 and 3cd5386, they are not ready yet.

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

Devin Hussey <husseydevin@xxxxxxxxx> wrote:
> From 65f9c258658b50aeb67947f5b54e926538560488 Mon Sep 17 00:00:00 2001
> From: Devin Hussey <husseydevin@xxxxxxxxx>
> Date: Thu, 15 Nov 2018 08:29:33 -0500
> Subject: [PATCH] Revert 78a00a7 and 3cd5386, they are not ready yet.
> 
> They are not ready, as simply running dash on its own configure
> script will reveal (note: config.cache does not exist):
> 
>    checking for a BSD-compatible install... (cached)
>    checking whether build environment is sane... yes
>    configure: 1: eval: --is-lightweight: not found
>    configure: WARNING: 'missing' script is too old or missing
>    checking for a thread-safe mkdir -p... (cached)  -p
>    checking for gawk... (cached) no
>    checking for mawk... (cached) no
>    checking for nawk... (cached) no
>    checking for awk... (cached) no
>    checking whether make sets $(MAKE)... (cached) configure: 1: test:
> =: unexpected operator
>    no
>    checking whether make supports nested variables... (cached)
>    configure: 2878: test: =: unexpected operator
>    checking for gcc... (cached) no
>    checking for cc... (cached) no
>    checking for cl.exe... (cached) no
>    configure: error: in `/Users/Devin/dash2':
>    configure: error: no acceptable C compiler found in $PATH
>    See `config.log' for more details
> 
> 3cd5386 completely broke expansion.
> 
> I got the configure script to run by changing
> 
>        return p - 1;
> 
> to
> 
>        return p;
> 
> in argstr, but variable expansion is still broken.
> 
> The most broken thing is ${FOO+BAR}:
> 
>    $ bash -c 'unset FOO; echo ${FOO+BAR}'
> 
>    $ ./dash -c 'unset FOO; echo ${FOO+BAR}'
>    BAR
>    $

Please look at the pending patches first.  These issues have
been fixed months ago:

https://patchwork.kernel.org/patch/10596841/

Unfortunately I haven't the time to push out the fix to the
git tree.  I'll do to that now.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt