Re: [PATCH] Fix some portability issues

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

Devin Hussey <husseydevin@xxxxxxxxx> wrote:
>
> -nl=`wc -l /tmp/ka$$`
> +nl=`wc -l $TMPDIR/ka$$`

Please quote TMPDIR since it's from the environment and can contain
arbitrary values.

> diff --git a/src/system.h b/src/system.h
> index a8d09b3..6b2e06a 100644
> --- a/src/system.h
> +++ b/src/system.h
> @@ -29,6 +29,7 @@
> #include <limits.h>
> #include <signal.h>
> #include <sys/types.h>
> +#include <string.h>
> 
> #ifndef SSIZE_MAX
> #define SSIZE_MAX ((ssize_t)((size_t)-1 >> 1))

Hmm, what in system.h uses string functions? Headers should be
added to the file that actually uses them.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html