Re: expand: Fix buffer overflow in expandmeta

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Mon, Mar 26, 2018 at 08:19:02AM +0200, Harald van Dijk wrote:
> On 3/26/18 7:12 AM, Herbert Xu wrote:
> >FWIW your patch when built with -O2 with gcc 4.7.2 is actually
> >16 bytes bigger than my version.
> 
> Interesting. Not sure what might cause that.

gcc likes to unroll things a lot which tends to duplicate code.
Sometimes I end up with three copies of the same code segment
just because gcc thinks it'll help remove branches.

None of this happens with -Os.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html