Re: expand: 'nolog' and 'debug' options cause "$-" to wreak havoc

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Tue, Mar 06, 2018 at 05:40:37PM +0000, Martijn Dekker wrote:
> Op 29-03-17 om 20:02 schreef Martijn Dekker:
> > Bug: if either the 'nolog' or the 'debug' option is set, trying to
> > expand "$-" silently aborts parsing of an entire argument.
> > 
> > $ dash -o nolog -c 'set -fuC; echo "|$- are the options|"; \
> > 	set +o nolog; echo "|$- are the options|"'
> > |
> > |uCf are the options|
> > $ dash -o debug -c 'set -fuC; echo "|$- are the options|"; \
> > 	set +o debug; echo "|$- are the options|"'
> > |
> > |uCf are the options|
> 
> This turned out to be easy to fix. The routine producing the "$-"
> expansion failed to skip options for which there is no option letter,
> but only a long-form name. In dash, 'nolog' and 'debug' are currently
> the only two such options. Patch below.

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html