Re: dash tested against ash testsuite: 17 failures

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Wed, Mar 07, 2018 at 07:49:16AM +0100, Harald van Dijk wrote:
>
> This was wrong in the original patch, but I'm not seeing it in the updated
> patch that you replied to. When parsing a heredoc where part of delimiter is
> quoted, syntax==SQSYNTAX. Since the calls to pgetc_eatbnl() are conditional
> on syntax!=SQSYNTAX, there shouldn't be a problem. It would be a different
> story if the delimiter could be an unquoted backslash, but thankfully that
> is not possible.

Good point.  In that case please resend it with the pgetc2 change
and it should be good to go.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html