Re: [PATCH] [MAN] 0 and EXIT both work for exit traps.

[Jonathan Nieder <jrnieder@xxxxxxxxx>]

Adam Buchbinder wrote:

> I saw a discussion in which there was some confusion over whether or not
> you can use a symbolic name, since the manpage doesn't specifically say so.

Looks good to me, with one nit:

[...]
> +	* Clarify that 0 and EXIT are both acceptable for exit traps.	

A trailing tab seems to have snuck in.

How about the following on top (for application with "am --scissors")?

-- >8 --
Subject: [MAN] Clarify "trap '' signals" syntax in manual page

When the manpage states

| <action> may be null, which cause the specified signals to be ignored.

it is not immediately obvious what it means for an action to be
null.  Clarify by explicitly referring to an empty string, as
opposed to a NULL pointer or the string "null".

Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
---
 ChangeLog  | 4 ++++
 src/dash.1 | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index f39999e9..d6536954 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2012-12-30  Jonathan Nieder  <jrnieder@xxxxxxxxx>
+
+	* Clarify "trap '' signals" syntax in manual page.
+
 2012-12-29  Adam Buchbinder <adam.buchbinder@xxxxxxxxx>
 
 	* Clarify that 0 and EXIT are both acceptable for exit traps.
diff --git a/src/dash.1 b/src/dash.1
index 3a1c2749..b47364d9 100644
--- a/src/dash.1
+++ b/src/dash.1
@@ -2076,7 +2076,9 @@ or
 .Li EXIT ,
 the action is executed when the shell exits.
 .Ar action
-may be null, which cause the specified signals to be ignored.
+may be empty
+.Li ( "''" ) ,
+which causes the specified signals to be ignored.
 With
 .Ar action
 omitted or set to `-' the specified signals are set to their default action.
-- 
1.8.1.rc3

--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html