[PATCH] Set SA_RESTART flag on SIGCHLD handler

[Anders Kaseorg <andersk@xxxxxxx>]

It looks like this was never forwarded to the dash mailing list.  Any 
thoughts from upstream?

Context: http://thread.gmane.org/gmane.comp.version-control.git.debian/147
(FTR, it did happen again.)

Anders

On Sun, 18 Mar 2012, Jonathan Nieder wrote:

> Anders Kaseorg wrote:
> 
> > So I guess I’m willing to just hope for now that this doesn’t happen
> > again.  (Unless you think it’s a dash bug that EINTR isn’t handled
> > there?)
> 
> Yes, I suspect it's a dash >= 0.5.6 bug.  On initialization dash sets
> up a signal handler for SIGCHLD without the SA_RESTART flag, which can
> cause other dash code to fail at seemingly random times.  Similar
> problems would arise when scripts set up traps.
> 
> diff --git i/src/trap.c w/src/trap.c
> index 17316c95..cd99596f 100644
> --- i/src/trap.c
> +++ w/src/trap.c
> @@ -259,7 +259,7 @@ setsignal(int signo)
>  		act.sa_handler = SIG_DFL;
>  	}
>  	*t = action;
> -	act.sa_flags = 0;
> +	act.sa_flags = SA_RESTART;
>  	sigfillset(&act.sa_mask);
>  	sigaction(signo, &act, 0);
>  }
> 
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html