On 02/25/2012 07:31 AM, Herbert Xu wrote: > On Sat, Feb 25, 2012 at 03:30:04PM +0100, Jilles Tjoelker wrote: >> >> Most shells pass the environment variable through, such as bash, zsh, >> ksh93 and most ash derivatives. However, the original Bourne shell and >> pdksh/mksh do not. > > Do you know of any genuine uses of such environment variables? POSIX states that applications must not rely on such pass-through: http://austingroupbugs.net/view.php?id=168 So while it might indeed be useful to pass through invalid names, such an application is broken for expecting it to work, and I'm okay with this patch as-is. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
