Re: [PATCH] [SHELL] Fix klibc DEBUG compilation v2

[maximilian attems <max@xxxxxxx>]

On Fri, 08 Jul 2011, Herbert Xu wrote:

> On Sat, Jun 04, 2011 at 09:15:49AM +0200, maximilian attems wrote:
> > dash didn't compile in DEBUG mode against klibc for all long time.
> > Now it only fails at link stage for not having setlinebuf(3) and
> > freopen(3).
> > 
> > Fixes:
> > 
> > usr/dash/show.o: In function `opentrace':
> > show.c:(.text+0x36): undefined reference to `freopen'
> > show.c:(.text+0x86): undefined reference to `setlinebuf'
> > 
> > Skip setlinebuf and use fclose/fopen inside SMALL.
> > 
> > Signed-off-by: maximilian attems <max@xxxxxxx>
> 
> Please change this to use a klibc-specific ifdef instead of everyone
> that uses SMALL.
> 

ok, sent patch with klibc specific '__KLIBC__`.

noticed latest dash release, will sync soon. 
unfortunately ee5cbe9fd6bc02f31b4d955606288de36c3d4eab complicates
a bit klibc sync, because mktokens now generates a third file
(we already have Kbuild hacks for the 2 generated files).

thank you.

-- 
maks
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html