Re: [PATCH 4/4] [MAIN] Optimize dash -c "command" to avoid a fork

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxxx>]

On Thu, Jul 07, 2011 at 03:37:03AM -0500, Jonathan Nieder wrote:
> Herbert Xu wrote:
> > On Thu, Jul 07, 2011 at 02:48:56AM -0500, Jonathan Nieder wrote:
> 
> >> mksyntax #include-s parser.h, so after a "make clean":
> >> 
> >> 	gcc -include ../config.h -DBSD=1 -DSHELL -DIFS_BROKEN  -g -Os -Wall -o mksyntax mksyntax.c
> >> 	In file included from mksyntax.c:43:0:
> >> 	parser.h:37:19: fatal error: token.h: No such file or directory
> >> 
> >> The following (on top) fixes it here.
> >
> > Oops, does this patch fix it?
> 
> Yes, thanks!  Silly me, mistaking mksyntax for mktokens...
> 
> The following works, too.
> ---
> diff --git i/src/Makefile.am w/src/Makefile.am
> index 05ed70a1..de193dd4 100644
> --- i/src/Makefile.am
> +++ w/src/Makefile.am
> @@ -65,5 +65,7 @@ syntax.c syntax.h: mksyntax
>  signames.c: mksignames
>  	./$^
>  
> +mksyntax: token.h
> +
>  $(HELPERS): %: %.c
>  	$(COMPILE_FOR_BUILD) -o $@ $<

Thanks, I'll kill the redundant command.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html