Re: [PATCH] JOBS: fix klibc DEBUG compilation

[maximilian attems <max@xxxxxxx>]

On Fri, Jun 03, 2011 at 08:13:02PM +0200, Jilles Tjoelker wrote:
> >  src/show.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> > diff --git a/src/show.c b/src/show.c
> > index 14dbef3..b4160e1 100644
> > --- a/src/show.c
> > +++ b/src/show.c
> > @@ -394,7 +394,9 @@ opentrace(void)
> >  	if ((flags = fcntl(fileno(tracefile), F_GETFL, 0)) >= 0)
> >  		fcntl(fileno(tracefile), F_SETFL, flags | O_APPEND);
> >  #endif
> > +#ifndef SMALL
> >  	setlinebuf(tracefile);
> > +#endif /* SMALL */
> >  	fputs("\nTracing started.\n", tracefile);
> >  }
> >  #endif /* DEBUG */
> 
> Why not just replace the non-standard setlinebuf() call with the
> standard  setvbuf(tracefile, NULL, _IOLBF, 0);  ? This appears to work
> just as well on FreeBSD and is C99 compliant (no POSIX needed here).
> 
> The #define SMALL is only for disabling line editing and history (using
> libedit). Setting the trace file line buffered is useful regardless of
> that.

If one doesn't support libedit one is assumed to define SMALL
and klibc does such.
http://www.spinics.net/lists/dash/msg00311.html

oh and I seem to not have recieved Herbert's answer from last Sept.
http://www.spinics.net/lists/dash/msg00367.html

I'll respin the patch based on it, thank you.

-- 
maks
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html