Re: (fwd) dash fix for job control off warning

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Fri, Apr 02, 2010 at 04:32:20PM +0200, maximilian attems wrote:
>
> Pulled this; there seems to be a problem with the new version of dash
> with job control off.  I can't tell if it is just a warning or is a
> manifest bug.
> 
> The solution is simple:
> 
> --- a/usr/dash/jobs.h
> +++ b/usr/dash/jobs.h
> @@ -105,5 +105,5 @@ int waitforjob(struct job *);
>  int stoppedjobs(void);
> 
>  #if ! JOBS
> -#define setjobctl(on)  /* do nothing */
> +#define setjobctl(on) ((void)(on))     /* do nothing */
>  #endif
> 
> ... to keep the code syntactically valid even when setjobctl() is used
> as the body of an if statement.

So when exactly is this needed? Can you give an example?

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html