Re: [Fwd: Small addon to saslauthd ldap support to add native Solaris LDAP SSL (LDAPS) support]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Howard Chu wrote:
Ken Murchison wrote:
Can one of the LDAP gurus take a look at this patch and let me know if
it looks sane, or if it can be rewritten to be smaller and/or leverage
more OpenLDAP code?

Well, the point is that it's trying to support the Solaris LDAP SDK, which is based on the ancient LDAPv2 API spec. If they're trying to use that, then they obviously can't leverage any OpenLDAP code.

I glazed over a bit reading his ldap_initialize() wrapper. The rest looked ok, but I'm suspicious of his #ifdef'ing standard options like LDAP_OPT_TIMELIMIT. Those should be supported on all LDAP APIs. The only things that ought to need ifdef'ing are options with "_X_" in their name as those are extensions that were never mentioned in any API spec (draft or otherwise).

Howard,

Thanks for the review. Is there something technically wrong with the ldap_initialize() wrapper, or is it just a style thing?


--
Kenneth Murchison
Systems Programmer
Project Cyrus Developer/Maintainer
Carnegie Mellon University

[Index of Archives]     [Info Cyrus]     [Squirrel Mail]     [Linux Media]     [Yosemite News]     [gtk]     [KDE]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux