On Fri, 2006-12-01 at 22:57 +0200, Fabian Fagerholm wrote: > The attached patch allows the string to be CRLF-terminated. Could this > go into the next version? Actually, more testing reveals that in practise -- such as when testing with sasl-sample-client -- the string could be LF-terminated, and so it could theoretically be CR-terminated as well. In addition, the patch had some other flaws. Here's a new one. Debian bug #400955 has the whole story: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=400955 Any comments? In particular, what is the idea here? Are applications supposed to be stripping off anything that doesn't belong to the base64 data, or is this unintentional? In case it helps, this is the change that altered the behaviour of sasl_decode64: https://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/sasl/lib/saslutil.c.diff?r1=1.43&r2=1.44 Thanks, -- Fabian Fagerholm <fabbe@xxxxxxxxx>
Attachment:
0015_saslutil_decode64_fix.dpatch
Description: application/shellscript
Attachment:
signature.asc
Description: This is a digitally signed message part
