Re: loop-AES: passing command line arguments to init [patch]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 28, 2003 at 20:13:35 +0200, Jari Ruusu wrote:

> How about this one? Your patch had little bit messed up parameter and
> environment processing. This version simply copies what kernel passed to
> linuxrc and passes them directly to init. This version also includes the
> insmod.modutils patch that you sent me earlier.

That's fine with me, I'm currently in need of runlevel selection only.
Your patch looks like it would be harder to remove linuxrc-specific
arguments if this shall be implemented some day. And init will get
argv[0] "linuxrc", but that's a cosmetic mistake, I don't know whether
changing argv[0] is portable.

> @@ -337,12 +348,21 @@
>      doHalt();
>  }
>  
> +#if ${USEDIETLIBC}
> +int main(int argc, char **argv)
                                 ^
Is "char **environ" missing here?

> +#else
>  void _start()
> +#endif
>  {
>      int x = 0;
>      struct utsname un;

> When sending patches for loop-AES, please CC me if you want me to see them.
> I'm usually subscribed to linux-crypto list, but every now and then I get
> silently dropped from the list.  :(

All right. I didn't test your patch yet, will do soon...

Thanks! -- Martin
-
Linux-crypto:  cryptography in and on the Linux system
Archive:       http://mail.nl.linux.org/linux-crypto/



[Index of Archives]     [Kernel]     [Linux Crypto]     [Gnu Crypto]     [Gnu Classpath]     [Netfilter]     [Bugtraq]
  Powered by Linux