On Wed, Oct 18, 2000 at 01:25:24PM +0200, Alexander S A Kjeldaas wrote: > On Tue, Oct 17, 2000 at 03:52:43PM +0000, Marc Mutz wrote: > > Hi! > > > > I've noticed that quite a lot of stuff in crypto.h is unneeded. In > > particular, all the encrypt/decrypt/set_key declarations don't need to > > be there, since the symbols aren't exported anyway and placing them in > > the crypto.h file might make people do the wrong thing and calling them > > directly. > > I agree that we need some changes, but I think going the other way is > better :-). Keep the functions in crypto.h, but add even more. > Include the *_cbc and *_ecb versions, and wrap the various > declarations in #ifdef CONFIG_CIPHER_XXX ... #endif pairs. No, this doesn't make sense at all. Adding every function in a whole class of modules to one header is not a good idea. Because it strikes against modular additions outside the main (kerneli) tree. If you really want to make them aviable to the whole kernel add a separate header for each algorithm, like <crypto/des.h> or <crypto/blowfish.h>. Anyway you have to export the symbols using EXPORT_SYMBOL, too. Christoph -- Always remember that you are unique. Just like everyone else. Linux-crypto: cryptography in and on the Linux system Archive: http://mail.nl.linux.org/linux-crypto/
