Herbert Valerio Riedel wrote: > the patch I sent to andrea is quite minimal, it only changes the IV > metric, and adds a few #define's to loop.h in order to recognize the IV > metric when compiling filter modules against it; as to jari's patch, if > the following def's were added, it can be used instead of my minimal > patch... > > /* definitions for IV metric */ > #define LOOP_IV_SECTOR_BITS 9 > #define LOOP_IV_SECTOR_SIZE (1 << LOOP_IV_SECTOR_BITS) > > typedef int loop_iv_t; > > ...except maybe for when backward compatibility is needed. As it is a > major concern to some of us to be able to convert their old iv-metric > encrypted volumes to the new "atomic"-IV-metric, it can be usefull to be > able to have both IV metrics available on the same system... Not changing IV parameter type in 2.4 kernels is important. Break that in 2.5/2.6 kernels, but not in stable 2.4, ok? Older 2.4 kernels dont't have loop_iv_t, and being able to compile _existing_ modules for them is important. 512 byte IV is nothing new, you know that, and all sane systems have used 512 byte IV for a long time already. So the 'block size IV' change to '512 byte IV' is nothing new, but changing the parameter type is evil and should be avoided for compatibility sake. > ps: just to make one thing clear (again), I don't care too much whether > my loop-fix or jari's goes in; I primarily care for a fixed IV situation > (including the above mentioned #define's/typedef) and if possible anyhow > to allow for limited compatibility to the old metric... So the choice here is either break (or at least cause need to modify) all other implementations or cryptoapi implementation. Herbert, if this loop_iv_t type goes into mainline kernel, I will have to reverse that on loop-AES patches for backward compatibility. Dependency on above mentioned #define's/typedef on kernel include files is silly, as cryptoapi can define them on any of its own include files. Regards, Jari Ruusu <jari.ruusu@pp.inet.fi> - Linux-crypto: cryptography in and on the Linux system Archive: http://mail.nl.linux.org/linux-crypto/
