Re: [PATCH] cpufreq: powernv: make local function static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11 May 2014 13:21, Brian Norris <computersforpeace@xxxxxxxxx> wrote:
> powernv_cpufreq_get() is only referenced in this file.
>
> Signed-off-by: Brian Norris <computersforpeace@xxxxxxxxx>
> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> Cc: cpufreq@xxxxxxxxxxxxxxx
> Cc: linux-pm@xxxxxxxxxxxxxxx
> ---
>  drivers/cpufreq/powernv-cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
> index af4968813e76..bb1d08dc8cc8 100644
> --- a/drivers/cpufreq/powernv-cpufreq.c
> +++ b/drivers/cpufreq/powernv-cpufreq.c
> @@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg)
>   * firmware for CPU 'cpu'. This value is reported through the sysfs
>   * file cpuinfo_cur_freq.
>   */
> -unsigned int powernv_cpufreq_get(unsigned int cpu)
> +static unsigned int powernv_cpufreq_get(unsigned int cpu)

Please make this as static as well: cpufreq_freq_attr_cpuinfo_nominal_freq

and add my

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> on V2.
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux