Hi Rafael, On 04/10 10:18, Rafael J. Wysocki wrote: > On Wednesday, April 09, 2014 09:58:26 AM Viresh Kumar wrote: >> On 9 April 2014 08:04, Kefeng Wang <wangkefeng.wang@xxxxxxxxxx> wrote: >>> When make ARCH=arm multi_v7_defconfig, we get the following warnings: >>> >>> warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has >>> unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK >>> && REGULATOR && OF && THERMAL && CPU_THERMAL) >>> >>> To fix this, make ARM_HIGHBANK_CPUFREQ depend on ARCH_HAS_CPUFREQ and >>> REGULATOR instead of selecting them, PM_OPP will be selected by ARCH_HAS_CPUFREQ. >>> >>> Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx> > > Well, it doesn't work as intended, I'm afraid: > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge > head: 588bc73d890c5dea35b7982a368c0e95089d5389 > commit: 51be80edc69390521622df71855d86da4e358488 [67/68] cpufreq: highbank: fix ARM_HIGHBANK_CPUFREQ dependency warning > config: make ARCH=i386 allyesconfig > > All warnings: > > warning: (GENERIC_CPUFREQ_CPU0 && ARM_BIG_LITTLE_CPUFREQ && ARM_EXYNOS5440_CPUFREQ) selects PM_OPP which has unmet direct dependencies (ARCH_HAS_OPP) I don't think this is my issue, without this patch，the warning is still there. warning: (GENERIC_CPUFREQ_CPU0 && ARM_BIG_LITTLE_CPUFREQ && ARM_EXYNOS5440_CPUFREQ && ARM_HIGHBANK_CPUFREQ) selects PM_OPP which has unmet direct dependencies (ARCH_HAS_OPP) this warning is caused by commit 109df086e(cpufreq: Select PM_OPP rather than depending on it), so could you merge this patch? I will send a revert patch to solve this issue, what is your opinion? Regards, Kefeng > >>> --- >>> drivers/cpufreq/Kconfig.arm | 6 +----- >>> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> >> -- >> To unsubscribe from this list: send the line "unsubscribe cpufreq" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
