On Wednesday, February 26, 2014 02:16:51 PM josh@xxxxxxxxxxxxxxxx wrote: > On Wed, Feb 26, 2014 at 10:56:45PM +0100, Rafael J. Wysocki wrote: > > On Wednesday, February 26, 2014 10:12:42 PM Rashika Kheria wrote: > > > Mark function as static in cpufreq.c because it is not > > > used outside this file. > > > > > > This eliminates the following warning in cpufreq.c: > > > drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for ‘show_boost’ [-Wmissing-prototypes] > > > > > > Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx> > > > > v2 has been Reviewed-by: Josh already, right? > > Feel free to forward-propagate to v3 as well, if that helps. OK Applied, thanks! > > > --- > > > Changes since v1: > > > Incorrect Fix > > > Changes since v2: > > > Show Changelog > > > > > > drivers/cpufreq/cpufreq.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > > index 08ca8c9..54fd670 100644 > > > --- a/drivers/cpufreq/cpufreq.c > > > +++ b/drivers/cpufreq/cpufreq.c > > > @@ -352,7 +352,7 @@ EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition); > > > /********************************************************************* > > > * SYSFS INTERFACE * > > > *********************************************************************/ > > > -ssize_t show_boost(struct kobject *kobj, > > > +static ssize_t show_boost(struct kobject *kobj, > > > struct attribute *attr, char *buf) > > > { > > > return sprintf(buf, "%d\n", cpufreq_driver->boost_enabled); > > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html