Hi Mike, On 02/24/2014 11:51 PM, Mike Turquette wrote: > Quoting Nishanth Menon (2014-02-18 12:32:18) >> From: Mike Turquette <mturquette@xxxxxxxxxx> >> >> This patch provides helper functions for drivers that wish to scale >> voltage through the clock rate-change notifiers. The approach taken >> is that the user-driver(cpufreq/devfreq) do not care about the >> details of the OPP table, nor does it care about handling the voltage >> regulator directly. >> >> By using the clk notifier flags, we are able to sequence the operations >> in the right order. The current logic is heavily influenced by >> implementation done in cpufreq-cpu0. >> >> [nm@xxxxxx: Fixes in logic, and broken out from clk to allow building >> a generic voltagedomain solution independent of cpufreq] >> Signed-off-by: Nishanth Menon <nm@xxxxxx> >> Signed-off-by: Mike Turquette <mturquette@xxxxxxxxxx> > > Not-signed-off-by: Mike Turquette <mturquette@xxxxxxxxxx> > > I haven't reviewed this series and it is a pretty big deviation from my > original RFC. You can have authorship of the patches if you want. Sure, I had send a private note requesting clarification about the authorship, but I guess I can take this as the response :). > > I'm not sure about trying to capture the "voltdm" as a core concept. It > feels a bit unwieldy to me. Considering it is a simple collation of regulators and SoC specific "magic" which have to be operated in tandem to clock operation, Why does it seem unwieldy? Usage of multiple voltage planes in a single voltage domain concept does not seem unique to TI processors either: For example, imx6q-cpufreq.c uses 3 regulators (arm, pu, soc), s5pv210-cpufreq.c uses two regulators (vddarm, vddint), ideally OMAP implementation would use two (vdd_mpu, vbb_mpu). > I have wondered about making an abstract > "performance domain" which is the dvfs analogue to generic power > domains. This a reasonable split since gpd are good for idle power > savings (e.g. clock gate, power gate, sleep state, etc) and "perf > domains" would be good for active power savings (dvfs). > > Having a generic container for performance domains might make a good > place to stuff all of this glue logic that we keep running into (e.g. > CPU and GPU max frequencies that are related), and it might make another > nice knob for the thermal folks to use. This sounds like one level higher abstraction that we are speaking of here? I was'nt intending to solve the bigger picture problem here - just an abstraction level that might allow reusablity for multiple SoCs. In fact, having an abstraction away for voltage domain(which may consist of multiple regulators and any SoC specific magic) purely allows us to move towards a direction you mention here. > > For the case of the OMAP voltage domains, it would be a place to stuff > all of the VC/VP -> ABB -> Smart Reflex AVS stuff. > Unfortunately, I dont completely comprehend objection we have to this approach (other than an higher level abstraction is needed) and if we do have an objection, what is the alternate approach should be for representing hardware which this series attempts to present. -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
