On 15 February 2014 01:12, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: > On 02/12/2014 11:50 PM, Viresh Kumar wrote: >> This patchset creates/calls cpufreq suspend/resume callbacks from dpm_{suspend|resume}() >> for handling suspend/resume of cpufreq governors and core. > > Are these patches for 3.14 or 3.15? 3.15 > I ask because I just tested Linus's master from a few days back (some > point after v3.14-rc2; commit 9398a10cd964 Merge tag > 'regulator-v3.14-rc2'), and I see a lot of the following messages during > suspend and/or resume (about 2-7 times, perhaps more of them from the > resume path, but it's hard to tell): > > cpufreq: __cpufreq_driver_target: Failed to change cpu frequency: -16 That's because you return -EBUSY from your tegra_cpu_init() once suspend/resume has started. Probably the print message is new here, and so you are able to see it failing.. Nothing else should have changed otherwise. > This series does appear to solve those, so I think at least part of it > needs to be applied for 3.14. Because we disallow calls to __cpufreq_driver_target() after suspend/ resume have started. > Also, I sometimes see the following during resume. I saw it twice with > Linus's tree, but then I did 10 more reboot+suspend+resume cycles and > couldn't repro it, and I saw it once with Linus's tree plus this series > applied, then couldn't reproduce it in 5 more tries. > Do you have any idea what the problem might be, and how to solve it? Not yet, will check.. -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html