> -----Original Message----- > From: Viresh Kumar [mailto:viresh.kumar@xxxxxxxxxx] > Sent: Wednesday, January 22, 2014 2:43 PM > To: Li, Zhuangzhi > Cc: Rafael J. Wysocki; cpufreq@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; > Linux Kernel Mailing List; Liu, Chuansheng > Subject: Re: [PATCH] cpufreq: Align all CPUs to the same frequency if using > shared clock > > On 22 January 2014 11:56, Li, Zhuangzhi <zhuangzhi.li@xxxxxxxxx> wrote: > > I don't think it's a real bug in bootloader, the bootloader can set > > CPUs to different frequencies according to actually requirements(Power > > saving first or Performance first), the CPUs freq policy are initialized in kernel, > if the kernel want to share one CPU policy(using CPUFREQ_SHARED_TYPE_ALL > type), it should ensure all CPUs frequencies aligned first, don't depend on the > bootloader CPUs Pre-states, then the kernel can have better compatibility. > > > > If the kernel uses CPUFREQ_SHARED_TYPE_ALL policy, the patch can ensure > these: > > 1. If all CPUs are in the same P-state, it does nothing when cpufreq > > registering 2. If the CPUs are in different P-states, all the other CPUs are > aligned once to current frequency of CPU0 according to the present policy. > > I thought, as you are asking kernel to keep same freq on all of them, then same > should be true for bootloaders. > > Otherwise it was okay. Yes, but most of the platforms(ARM&x86) only enable one CPU Core in bootloader or Bios because of multiple threads(SMP) are not supported, and the other Cores stay in default configuration for saving power in bootloader, kernel is responsible for booting up the other Cores from default frequencies for SMP. Cpufreq driver need to init them to required P-state before governor active when using CPUFREQ_SHARED_TYPE_ALL policy. -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
