On 23 December 2013 11:25, Bjørn Mork <bjorn@xxxxxxx> wrote: > I can confirm that it fixes the major regression. With this branch, the > cpufreq directory is completely removed after a cancelled userspace > hibernate (with the acpi-cpufreq problem causing failure). So it is > possible to restore cpufreq by manually offlining and onlining non-boot > cores. No more leftover sysfs attributes. Thanks for giving it a try once again :) > But there is still a minor regression compared to the old (v3.11) > behaviour: Previously the cpufreq functionality would be automatically > restored by any completed hibernate or suspend cycle, since it would > effectively do the CPU offline/online. This automatix fixup won't happen > with the current pm-cpufreq branch. I didn't understood it completely, sorry :) As far as I can see from 3.11 code we simply used to fail with any failure resulting with a call to ->init() or some other call.. And so cpufreq wouldn't have added any directories at all in that case. And so I think we still required an offline/online sequence to guarantee things.. -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html