[Bug 66751] [BISECTED]Does not resume from suspend (bisected)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.kernel.org/show_bug.cgi?id=66751

--- Comment #3 from Bjørn Mork <bjorn@xxxxxxx> ---
Yes, this is a pretty interesting one. The bug is caused by the combination of
two commits added between -rc2 and -rc3:

 5a87182aa21d cpufreq: suspend governors on system suspend/hibernate
 2167e2399dc5 cpufreq: fix garbage kobjects on errors during suspend/resume

The order these are applied is really arbitrary, and the bisect will point to
the last one applied. Which happens to be 2167e2399dc5. But I will still claim
that it was commit 5a87182aa21d that caused this bug by adding even more
special handling of cpufreq suspend.  This needs to be done properly if it is
done at all, including hooks for drivers and governors. Adding special cases
and "if suspending" tests here and there with subtle implicit dependencies
between the different code blocks is not going to fly.

Note that reverting only 5a87182aa21d will fix the problem, with simpler code
and no dangling sysfs files as a result.

-- 
You are receiving this mail because:
You are the assignee for the bug.--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux