On Thursday, November 07, 2013 10:39:38 AM Viresh Kumar wrote: > On 7 November 2013 07:58, Xiaoguang Chen <chenxg@xxxxxxxxxxx> wrote: > > When decreasing frequency, requested_freq may be less than > > freq_target, So requested_freq minus freq_target may be negative, > > But reqested_freq's unit is unsigned int, then the negative result > > will be one larger interger which may be even higher than > > requested_freq. > > > > This patch is to fix such issue. when result becomes negative, > > set requested_freq as the min value of policy. > > > > Signed-off-by: Xiaoguang Chen <chenxg@xxxxxxxxxxx> > > --- > > drivers/cpufreq/cpufreq_conservative.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > Good Catch. > > Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> Applied, thanks! > We need another patch for fixing the other part of code where we > increase freq.. > We need to replace: > > if (dbs_info->requested_freq == policy->max) > return; > > with > > if (dbs_info->requested_freq >= policy->max) > return; > > So, that we don't run unnecessary code :) Care to prepare a patch? -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
