On 12/10/2013, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote: > On Friday, October 11, 2013 07:27:44 PM Viresh Kumar wrote: >> On 11/10/2013, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote: >> > So I've just added this to bleeding-edge, but I have a couple >> > complaints. >> >> Thanks.. >> >> > First off, this is three patch sets in one. The first part is the >> > generic >> > .attr(), exit() and .verify() one, the second part is the duplicated >> > initialization and the third one is about cpufreq_generic_init(). They >> > really should have been posted and reviewed separately. >> >> They were posted and reviewed separately earlier.. Only this time >> I have merged them together for applying.. >> >> > And while I'm basically OK with the first and the third part, I'm >> > concerned >> > about the second one, because it has potential to introduce some subtle >> > initialization issues (initializing something twice is not a bug per >> > se, >> > although it is inefficient, but failing to initialize that or >> > initializing >> > it >> > with an incorrect value *is* a bug). >> >> I agree.. Lets see if it breaks anything... I will get it fixed as soon >> as >> possible.. (BTW, there was a fixup for the last series that you missed >> to apply: fixup! cpufreq: sa11x0: Expose frequency table) > > Any links? https://lkml.org/lkml/2013/10/4/7 Attached again..
From d2e1eb969ebdb66e3cc199fbbbe2e2a1a8e2960b Mon Sep 17 00:00:00 2001 Message-Id: <d2e1eb969ebdb66e3cc199fbbbe2e2a1a8e2960b.1381541098.git.viresh.kumar@xxxxxxxxxx> From: Viresh Kumar <viresh.kumar@xxxxxxxxxx> Date: Fri, 4 Oct 2013 10:48:16 +0530 Subject: [PATCH] fixup! cpufreq: sa11x0: Expose frequency table --- arch/arm/mach-sa1100/generic.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/mach-sa1100/generic.h b/arch/arm/mach-sa1100/generic.h index f5214ce..2d9bee0 100644 --- a/arch/arm/mach-sa1100/generic.h +++ b/arch/arm/mach-sa1100/generic.h @@ -3,6 +3,7 @@ * * Author: Nicolas Pitre */ +#include <linux/cpufreq.h> #include <linux/reboot.h> extern void sa1100_timer_init(void); @@ -19,8 +20,6 @@ extern void sa11x0_init_late(void); extern void sa1110_mb_enable(void); extern void sa1110_mb_disable(void); -struct cpufreq_policy; - extern struct cpufreq_frequency_table sa11x0_freq_table[]; extern unsigned int sa11x0_freq_to_ppcr(unsigned int khz); extern int sa11x0_verify_speed(struct cpufreq_policy *policy); -- 1.7.12.rc2.18.g61b472e
