On 10/02/2013 02:13 PM, Viresh Kumar wrote:
> Lets use cpufreq_driver->flags to mark CPUFREQ_HAVE_GOVERNOR_PER_POLICY instead
> of a separate field within cpufreq_driver. This will save some bytes for us.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> ---
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@xxxxxxxxxxxxxxxxxx>
Regards,
Srivatsa S. Bhat
> drivers/cpufreq/arm_big_little.c | 4 ++--
> drivers/cpufreq/cpufreq.c | 2 +-
> drivers/cpufreq/cpufreq_governor.h | 5 ++++-
> include/linux/cpufreq.h | 15 ++++++++-------
> 4 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c
> index 9acfb82..2c7c134 100644
> --- a/drivers/cpufreq/arm_big_little.c
> +++ b/drivers/cpufreq/arm_big_little.c
> @@ -213,13 +213,13 @@ static struct freq_attr *bL_cpufreq_attr[] = {
>
> static struct cpufreq_driver bL_cpufreq_driver = {
> .name = "arm-big-little",
> - .flags = CPUFREQ_STICKY,
> + .flags = CPUFREQ_STICKY |
> + CPUFREQ_HAVE_GOVERNOR_PER_POLICY,
> .verify = bL_cpufreq_verify_policy,
> .target = bL_cpufreq_set_target,
> .get = bL_cpufreq_get,
> .init = bL_cpufreq_init,
> .exit = bL_cpufreq_exit,
> - .have_governor_per_policy = true,
> .attr = bL_cpufreq_attr,
> };
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 267ae99..23e0a40 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -92,7 +92,7 @@ static DEFINE_MUTEX(cpufreq_governor_mutex);
>
> bool have_governor_per_policy(void)
> {
> - return cpufreq_driver->have_governor_per_policy;
> + return !!(cpufreq_driver->flags & CPUFREQ_HAVE_GOVERNOR_PER_POLICY);
> }
> EXPORT_SYMBOL_GPL(have_governor_per_policy);
>
> diff --git a/drivers/cpufreq/cpufreq_governor.h b/drivers/cpufreq/cpufreq_governor.h
> index 88cd39f..b5f2b86 100644
> --- a/drivers/cpufreq/cpufreq_governor.h
> +++ b/drivers/cpufreq/cpufreq_governor.h
> @@ -191,7 +191,10 @@ struct common_dbs_data {
> struct attribute_group *attr_group_gov_sys; /* one governor - system */
> struct attribute_group *attr_group_gov_pol; /* one governor - policy */
>
> - /* Common data for platforms that don't set have_governor_per_policy */
> + /*
> + * Common data for platforms that don't set
> + * CPUFREQ_HAVE_GOVERNOR_PER_POLICY
> + */
> struct dbs_data *gdbs_data;
>
> struct cpu_dbs_common_info *(*get_cpu_cdbs)(int cpu);
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index 9321059..6c9c365 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -194,13 +194,6 @@ __ATTR(_name, 0644, show_##_name, store_##_name)
> struct cpufreq_driver {
> char name[CPUFREQ_NAME_LEN];
> u8 flags;
> - /*
> - * This should be set by platforms having multiple clock-domains, i.e.
> - * supporting multiple policies. With this sysfs directories of governor
> - * would be created in cpu/cpu<num>/cpufreq/ directory and so they can
> - * use the same governor with different tunables for different clusters.
> - */
> - bool have_governor_per_policy;
>
> /* needed by all drivers */
> int (*init) (struct cpufreq_policy *policy);
> @@ -234,6 +227,14 @@ struct cpufreq_driver {
> #define CPUFREQ_PM_NO_WARN (1 << 2) /* don't warn on suspend/resume
> speed mismatches */
>
> +/*
> + * This should be set by platforms having multiple clock-domains, i.e.
> + * supporting multiple policies. With this sysfs directories of governor would
> + * be created in cpu/cpu<num>/cpufreq/ directory and so they can use the same
> + * governor with different tunables for different clusters.
> + */
> +#define CPUFREQ_HAVE_GOVERNOR_PER_POLICY (1 << 3)
> +
> int cpufreq_register_driver(struct cpufreq_driver *driver_data);
> int cpufreq_unregister_driver(struct cpufreq_driver *driver_data);
>
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
