On 20 September 2013 02:33, Nishanth Menon <nm@xxxxxx> wrote: > opp_get_opp_count > opp_find_freq_exact > opp_init_cpufreq_table > opp_free_cpufreq_table The only problem I see is that routines names for few of them are getting really long now.. Otherwise not much I could find... Though you had following changes, which you could have avoided in this hard to review patchset: diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c new_opp = [-kzalloc(sizeof(struct opp),-]{+kzalloc(sizeof(*new_opp),+} GFP_KERNEL); new_opp = [-kmalloc(sizeof(struct opp),-]{+kmalloc(sizeof(*new_opp),+} GFP_KERNEL); It is almost impossible to catch these with naked eyes for such long patches.. I took help of --word-diff though :) If no one else sees these as problems then feel free to add my: Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html