On 09/10/2013 12:39 PM, Viresh Kumar wrote: > On 7 September 2013 01:23, Srivatsa S. Bhat > <srivatsa.bhat@xxxxxxxxxxxxxxxxxx> wrote: >> Commit "cpufreq: serialize calls to __cpufreq_governor()" had been a temporary >> and partial solution to the race condition between writing to a cpufreq sysfs >> file and taking a CPU offline. Now that we have a proper and complete solution >> to that problem, remove the temporary fix. >> >> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@xxxxxxxxxxxxxxxxxx> >> --- > > I would still vote for keeping this code or reverting this patch of yours.. > As there might be other scenarios, than hotplug races, where this serialization > would be useful.. > I would say it would be better to first explain those scenarios in detail, and then justify why this solution is the best one. Without that, it starts appearing more like premature optimization... and we all know the mess that it can lead to ;-) Regards, Srivatsa S. Bhat -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
