Re: [PATCH] cpufreq: add frequency table to at32ap driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13 August 2013 12:22, Hans-Christian Egtvedt <egtvedt@xxxxxxxxxxxx> wrote:
> Acked-by: Hans-Christian Egtvedt <egtvedt@xxxxxxxxxxxx>
>
> Thanks for cleaning up (-:

No problem..

Actually there is more to it.. We have got a freq table but neither .verify()
nor .target() uses it :) and so we need to fix those two also to fix it up..

.verify() looks to be pretty straight forward and so can be replaced by
the generic routine I wrote for that..

But .target() does some calculations which aren't very straight forward
to replace..

I believe I can remove all below code and simply get the frequency
as suggested by cpufreq-core ??

	/* Convert target_freq from kHz to Hz */
	freq = clk_round_rate(cpuclk, target_freq * 1000);

	/* Check if policy->min <= new_freq <= policy->max */
	if(freq < (policy->min * 1000) || freq > (policy->max * 1000))
		return -EINVAL;

	pr_debug("cpufreq: requested frequency %u Hz\n", target_freq * 1000);

	freqs.new = (freq + 500) / 1000;
	freqs.flags = 0;
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux