Re: 3.10-rcX: cpu governor ondemand doesn't scale well after s2ram

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday, June 29, 2013 07:50:11 PM Toralf Förster wrote:
> The latest bisect attempt gave :
> 
> commit a66b2e503fc79fff6632d02ef5a0ee47c1d2553d
> Author: Srivatsa S. Bhat <srivatsa.bhat@xxxxxxxxxxxxxxxxxx>
> Date:   Wed May 15 21:47:17 2013 +0200
> 
>     cpufreq: Preserve sysfs files across suspend/resume
> 
>     The file permissions of cpufreq per-cpu sysfs files are not preserved
>     across suspend/resume because we internally go through the CPU
>     Hotplug path which reinitializes the file permissions on CPU online.
> 
>     But the user is not supposed to know that we are using CPU hotplug
>     internally within suspend/resume (IOW, the kernel should not silently
>     wreck the user-set file permissions across a suspend cycle).
>     Therefore, we need to preserve the file permissions as they are
>     across suspend/resume.
> 
>     The simplest way to achieve that is to just not touch the sysfs files
>     at all - ie., just ignore the CPU hotplug notifications in the
>     suspend/resume path (_FROZEN) in the cpufreq hotplug callback.
> 
>     Reported-by: Robert Jarzmik <robert.jarzmik@xxxxxxxxx>
>     Reported-by: Durgadoss R <durgadoss.r@xxxxxxxxx>
>     Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@xxxxxxxxxxxxxxxxxx>
>     Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>     Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> 
> 
> 
> To get a more reliable bisect result I had to start BOINC before (4
> childs each with nice -19 started)

Well, to be honest, I'm not really sure how the above commit can cause the
problem you're seeing to happen ...

Srivatsa, Viresh, any ideas?

Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux