On Thu, Jun 27, 2013 at 08:39:12PM +0530, Viresh Kumar wrote: > On 27 June 2013 20:25, Jacob Shin <jacob.shin@xxxxxxx> wrote: > > diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c > > index 4b9bb5d..93eb5cb 100644 > > --- a/drivers/cpufreq/cpufreq_ondemand.c > > +++ b/drivers/cpufreq/cpufreq_ondemand.c > > @@ -47,6 +47,8 @@ static struct od_ops od_ops; > > static struct cpufreq_governor cpufreq_gov_ondemand; > > #endif > > > > +static unsigned int default_powersave_bias; > > Why are the above three changes required? And in case they are, then > they must have been commited separately. > > Because you haven't replied to my earlier comment on this, I > thought you agreed. But it looks you haven't read my first > reply well. Sorry I totally missed it, I was trying to account for the case when od_set_powersave_bias() is called while ondemand is not the current governor. And then later becomes the current governor. So when od_init() is called it will take the expected default, rather than 0. -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html