On 2013年06月26日 07:02, Rafael J. Wysocki wrote: > On Tuesday, June 25, 2013 04:19:14 PM Lan Tianyu wrote: >> On 2013年06月25日 15:48, Viresh Kumar wrote: >>> On 25 June 2013 12:24, Lan Tianyu <tianyu.lan@xxxxxxxxx> wrote: >>>> On 2013年06月25日 11:56, Viresh Kumar wrote: >>> >>>>> This is generic file, don't add this information here. Add this in >>>>> acpi-cpufreq file. >>>> I don't find acpi-cpufreq.txt under >>>> Documentation/cpu-freq/acpi-cpufreq.txt. So I should create it? >>> >>> I meant acpi-cpufreq.c file >> Ok. From my opinion, the new attribute is an ABI and it's better to add >> descriptor under Document directory. The user can be easy to find how to >> use it. > > Yes, this should be documented under Documentation/ABI/testing/. I find the following descriptor in the Documentation/ABI/testing/sysfs-devices-system-cpu. So I originally put the new attribute descriptor in the user-guide.txt. Now, creating new acpi-cpufreq file under Documentation/cpu-freq/ and adding the descriptor in the new file maybe a good choice? What: /sys/devices/system/cpu/cpu#/cpufreq/* Date: pre-git history Contact: cpufreq@xxxxxxxxxxxxxxx Description: Discover and change clock speed of CPUs Clock scaling allows you to change the clock speed of the CPUs on the fly. This is a nice method to save battery power, because the lower the clock speed, the less power the CPU consumes. There are many knobs to tweak in this directory. See files in Documentation/cpu-freq/ for more information. In particular, read Documentation/cpu-freq/user-guide.txt to learn how to control the knobs. > > Thanks, > Rafael > > -- Best regards Tianyu Lan -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html