On Tue, 2013-06-25 at 09:01 +0530, Viresh Kumar wrote: > On 25 June 2013 01:00, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote: > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c [] > > -static int __cpuinit cpufreq_cpu_callback(struct notifier_block *nfb, > > - unsigned long action, void *hcpu) > > +static int cpufreq_cpu_callback(struct notifier_block *nfb, > > + unsigned long action, void *hcpu) > > You were not required to change second line here and also don't > change its indentation level. Check this everywhere. Paul, yes, thanks for doing that here, but please, do it everywhere... ;) > > diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c [] > > @@ -306,7 +306,7 @@ static int cpufreq_stat_notifier_policy(struct notifier_block *nb, > > } > > > > static int cpufreq_stat_notifier_trans(struct notifier_block *nb, > > - unsigned long val, void *data) > > + unsigned long val, void *data) > > See.. unnecessary change. Or from another perspective, ideal change. > > -static int __cpuinit cpufreq_stat_cpu_callback(struct notifier_block *nfb, > > +static int cpufreq_stat_cpu_callback(struct notifier_block *nfb, > > unsigned long action, > > void *hcpu) Hey Paul, you missed some too. Viresh, there's no absolute "right" way to do this. -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
