2013/6/5 Viresh Kumar <viresh.kumar@xxxxxxxxxx>: > On 5 June 2013 18:07, Rafael J. Wysocki <rjw@xxxxxxx> wrote: >> On Wednesday, June 05, 2013 02:34:33 PM Viresh Kumar wrote: >>> Userspace governor has got more code than what it needs for its functioning. >>> Lets simplify it. >> >> OK >> >> Why exactly is the code you're removing unnecessary? >> >>> Over that it will fix issues in cpufreq_governor_userspace(), which isn't doing >>> right things in START/STOP. >> >> What exactly is the problem? > > I sent a reply now to the problem reported by Xiaoguang as I don't feel > now there is a problem :( > Yes, I think the problem will disappear since the related code is deleted. the original code path will not be executed. >>> It is working per-cpu currently whereas it just >>> required to manage policy->cpu. >>> >>> Reported-by: Xiaoguang Chen <chenxg.marvell@xxxxxxxxx> >>> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> >>> --- >>> @Rafael: >>> >>> I don't know why this code was initially added. Please let me know if I am doing >>> something stupid. >>> >>> Also, please apply it as a fix for 3.10 as it is broken recently in 3.9. >> >> I'd love to, but I need answers to the above questions before I do that. > > To be honest with the amount of experience I have now, my log was > poor :( > > I have used following log in the attached patch: > > Subject: [PATCH] cpufreq: userspace: Simplify governor > > Userspace governor has got more code than what it needs for its functioning. > Lets simplify it. Portions of code removed are: > - Extra header files which aren't required anymore (rearranged them as well) > - cpu_{max|min|cur|set}_freq, as they are always same as policy->{max|min|cur} > - userspace_cpufreq_notifier_block as we don't need to set cpu_cur_freq anymore > - cpus_using_userspace_governor as it was for notifier code > > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html