On Fri, May 31, 2013 at 3:45 PM, Ross Lagerwall <rosslagerwall@xxxxxxxxx> wrote:
>
> 4b31e774 fixed bug #4634 and caused the driver to always set the
> target P-State at least once since the initial P-State may not be the
> desired one. 5a1c0228 caused a regression in this behavior.
>
> This fixes the regression by setting policy->cur based on the CPU's
> target frequency rather than the CPU's current reported frequency
> (which may be different). This means the P-State will be set initially
> if the CPU's target frequency is different from the governor's target
> frequency.
>
> This fixes an issue where setting the default governor to performance
> wouldn't correctly enable turbo mode on all cores.
>
> Signed-off-by: Ross Lagerwall <rosslagerwall@xxxxxxxxx>
Reviewed-by: Len Brown <len.brown@xxxxxxxxx>
Ack -- MSR_IA32_PERF_STATUS is ill-conceived. It is un-reliable
by its very definition. Any code that depends on it should be questioned...
thanks,
Len Brown, Intel Open Source Technology Center
> ---
> drivers/cpufreq/acpi-cpufreq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 11b8b4b..edc089e 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -347,11 +347,11 @@ static u32 get_cur_val(const struct cpumask *mask)
> switch (per_cpu(acfreq_data, cpumask_first(mask))->cpu_feature) {
> case SYSTEM_INTEL_MSR_CAPABLE:
> cmd.type = SYSTEM_INTEL_MSR_CAPABLE;
> - cmd.addr.msr.reg = MSR_IA32_PERF_STATUS;
> + cmd.addr.msr.reg = MSR_IA32_PERF_CTL;
> break;
> case SYSTEM_AMD_MSR_CAPABLE:
> cmd.type = SYSTEM_AMD_MSR_CAPABLE;
> - cmd.addr.msr.reg = MSR_AMD_PERF_STATUS;
> + cmd.addr.msr.reg = MSR_AMD_PERF_CTL;
> break;
> case SYSTEM_IO_CAPABLE:
> cmd.type = SYSTEM_IO_CAPABLE;
> --
> 1.8.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe cpufreq" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Len Brown, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
