On Friday, May 17, 2013 10:13:37 AM Viresh Kumar wrote: > On 17 May 2013 02:21, Rafael J. Wysocki <rjw@xxxxxxx> wrote: > > While I kind of understand why you want [3/3] to go into 3.10, I'm wondering > > about the other two patches. Why exactly are they needed now? > > First one: > > cpufreq: Add EXPORT_SYMBOL_GPL for have_governor_per_policy > > is required so that governors can be compiled as module. Otherwise they > may break.. I haven't tried that but I believe that is the case. Did you try to build them as modules? > For second one: > > cpufreq: governors: Move get_governor_parent_kobj() to cpufreq.c > > I was actually working on Android's Interactive governor (Where I enabled > same per-policy-instance of governor support), And i required this patch > for its working. Then I thought other platform specific governors present > in mainline might also use this routine and so must be pushed to cpufreq.c. > > Now, because this patch is around due to something which got > added in 3.10-rc1, its better to fix it in rcs only rather than fixing > it in 3.11. OK, thanks for the explanation. > I will trust your judgement here, push it for 3.10-rc if it looks okay to you. > > > And speaking of patch [3/3], if you paste kernel logs into changelogs, please > > remove the time stamps (unless they are relevant to the problem being fixed). > > Okay.. Will keep that in mind. Thanks! Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
