https://bugzilla.kernel.org/show_bug.cgi?id=56691 Dirk Brandewie <dirk.brandewie@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dirk.brandewie@xxxxxxxxx --- Comment #2 from Dirk Brandewie <dirk.brandewie@xxxxxxxxx> 2013-04-16 17:45:39 --- This is the same bug as reported by Redhat https://bugzilla.redhat.com/show_bug.cgi?id=952244 I took a long time to reproduce and catch it in the act and get debug info :-( The fix missed rc6 by a few hours but is in rc7. --Dirk Author: Dirk Brandewie <dirk.brandewie@xxxxxxxxx> 2013-04-04 10:35:35 Committer: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> 2013-04-08 13:09:23 Parent: 05e99c8cf9d4e53ef6e016815db40a89a6156529 (intel-pstate: Use #defines instead of hard-coded values.) Branches: master, pstate, pstate.stgit, remotes/linux-pm/bleeding-edge, remotes/linux-pm/fixes, remotes/linux-pm/linux-next, remotes/next/akpm, remotes/next/akpm-base, remotes/next/master, remotes/next/stable, remotes/origin/master, test_next Follows: v3.9-rc6 Precedes: pm-3.9-rc7 cpufreq / intel_pstate: Set timer timeout correctly The current calculation of the delay time is wrong and a cut and paste error from a previous experimental driver. This can result in the timeout being set to jiffies + 1 which setup the driver to race with itself if the APIC timer interrupt happens at just the right time. References: https://bugzilla.redhat.com/show_bug.cgi?id=920289 Reported-by: Adam Williamson <awilliam@xxxxxxxxxx> Reported-and-tested-by: Parag Warudkar <parag.lkml@xxxxxxxxx> Signed-off-by: Dirk Brandewie <dirk.j.brandewie@xxxxxxxxx> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> ------------------------ drivers/cpufreq/intel_pstate.c ------------------------ index ad72922..6133ef5 100644 @@ -502,7 +502,6 @@ static inline void intel_pstate_set_sample_time(struct cpudata *cpu) sample_time = cpu->pstate_policy->sample_rate_ms; delay = msecs_to_jiffies(sample_time); - delay -= jiffies % delay; mod_timer_pinned(&cpu->timer, jiffies + delay); } -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
