On 8 April 2013 13:47, Amit Daniel Kachhap <amit.daniel@xxxxxxxxxxx> wrote:
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index f3f3b14..bce2195 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -42,6 +42,15 @@ config ARM_EXYNOS5250_CPUFREQ
> This adds the CPUFreq driver for Samsung EXYNOS5250
> SoC.
>
> +config ARM_EXYNOS5440_CPUFREQ
> + def_bool SOC_EXYNOS5440
> + depends on HAVE_CLK && PM_OPP && OF
Don't you need a depend on your Soc or mach or arch? Don't send another
version for this now.. Just send a new patch over this patchset.
> diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq/exynos5440-cpufreq.c
> +static int exynos_target(struct cpufreq_policy *policy,
> + unsigned int target_freq,
> + unsigned int relation)
> +{
> + unsigned int index, tmp;
> + int ret = 0, i;
> + struct cpufreq_frequency_table *freq_table = dvfs_info->freq_table;
> +
> + mutex_lock(&cpufreq_lock);
> + freqs.old = dvfs_info->cur_frequency;
> +
> + ret = cpufreq_frequency_table_target(policy, freq_table,
> + target_freq, relation, &index);
> + if (ret)
> + goto out;
> +
Move freqs.old = *** here.
> + freqs.new = freq_table[index].frequency;
> + freqs.cpu = policy->cpu;
You don't need this. Below call takes care of it.
Rest is fine.. Just resend this patch with all above issues fixed and i will Ack
it without any further reviews :)
Don't wait for few days for doing this, send it right now. :)
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
