Re: [PATCH] cpufreq/intel_pstate: Set timer timeout correctly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/04/13 10:19 PM, Viresh Kumar wrote:
On Thu, Apr 4, 2013 at 11:05 PM,  <dirk.brandewie@xxxxxxxxx> wrote:
From: Dirk Brandewie <dirk.brandewie@xxxxxxxxx>

The current calculation of the delay time is wrong and a cut and paste
error from a previous experimental driver.  This can result in the
timeout being set to jiffies + 1 which setup the driver to race with
it's self if the apic timer interrupt happen at just the right time.


https://bugzilla.redhat.com/show_bug.cgi?id=920289

Reported-by: Adam Williamson <awilliam@xxxxxxxxxx>
Reported-by: Parag Warudkar <parag.lkml@xxxxxxxxx>

Signed-off-by: Dirk Brandewie <dirk.brandewie@xxxxxxxxx>
---
  drivers/cpufreq/intel_pstate.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

Looks fine, but I would like to see a Tested-by from Adam/Parag
as they haven't said anything about this patch (even in bugzilla).

I'll try. Note the bug is not reliably reproducible, all I can really do is run for a day or two and see if it crashes.
--
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | identi.ca: adamwfedora
http://www.happyassassin.net
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux