On Thu, Apr 04, 2013 at 11:54:20PM +0200, Guennadi Liakhovetski wrote: > Hi Simon > > Thanks for the review > > On Thu, 4 Apr 2013, Simon Horman wrote: > > > On Sun, Mar 24, 2013 at 08:27:35PM +0100, Guennadi Liakhovetski wrote: > > > This patch enables the use of the generic cpufreq-cpu0 driver on kzm9g. > > > Providing a regulator, a list of OPPs in DT, combined with a virtual > > > cpufreq-cpu0 platform device and a clock, attached to it is everything, > > > the cpufreq-cpu0 driver needs. > > > > I wonder if it would be possible to re-arange this patch a little. > > > > 1) vdd_dvfs is added in this patch but it appears to be used in the > > previous patch in the series. I wonder if this can be resolved > > by re-ordering the patches. > > Right, I'll change that. > > > 2) It includes both kzm9g board and sh73a0 SoC changes. > > I would prefer if the sh73a0 SoC portion (setup-sh73a0.c) > > was moved into a separate patch. The arm-soc people > > like to have separate board and SoC branches. > > Yes, I'll probably just merge the sh73a0-kzm9g-reference.dts hunk into the > previous patch. Thanks, I think that approach should work well. -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
