On 27 March 2013 17:05, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote: > On 27 March 2013 15:34, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote: >> I am still stuck at a issue, which i am not able to fix. >> - cat of */cpufreq/ondemand/** isn't showing anything on console, but all >> pointers are correctly set and i can see the right values with printk() > > The culprit is the part where i changed prototypes of all show/store functions. > I am still trying to understand how that part works, and will fix it soon. It seems i have broken some other stuff too with this patch: commit 63173d01761a442ac5a7c73de996acbe9b0b3da7 Author: Viresh Kumar <viresh.kumar@xxxxxxxxxx> Date: Wed Feb 6 15:37:37 2013 +0530 cpufreq: Get rid of "struct global_attr" We don't need to keep two structures for file attributes, global_attr and freq_attr. Lets use freq_attr only for cpufreq core and drivers. Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> --- drivers/cpufreq/acpi-cpufreq.c | 9 ++++----- drivers/cpufreq/intel_pstate.c | 20 ++++++++++---------- include/linux/cpufreq.h | 16 ---------------- Atleast both acpi-cpufreq and intel_pstate (including cpufreq as a whole). :( And i don't want to post any more fixups now.. they are huge and will create more confusion.. Rather i will send next version of my patchset and ask Rafael to drop earlier patches. Will cc you, please try them at your end. -- viresh -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html