RE: [PATCH 3/3] cpufreq: Add cpufreq driver for Freescale e500mc SOCs

[Tang Yuantian-B29983 <B29983@xxxxxxxxxxxxx>]

> -----Original Message-----
> From: Viresh Kumar [mailto:viresh.kumar@xxxxxxxxxx]
> Sent: 2013年3月27日 16:43
> To: Tang Yuantian-B29983
> Cc: cpufreq@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 3/3] cpufreq: Add cpufreq driver for Freescale e500mc
> SOCs
> 
> >> > +static int corenet_cpufreq_verify(struct cpufreq_policy *policy) {
> >> > +       struct cpufreq_frequency_table *table;
> >> > +
> >> > +       table = (&per_cpu(cpu_data, policy->cpu))->table;
> >> > +       if (!table)
> >> > +               return -EINVAL;
> >
> >>
> >
> >> This should never be true.
> >
> > don't understand what's your point here. could you elaborate it?
> 
> Sure. table should always be vaild. How can this be NULL ever?

Are you saying the if statement is redundant?  It is sort of yes.

Thanks for your time and I will incorporate your comments in next version.

-Yuantian
?韬{.n?????%??檩??w?{.n???珉z??^n?■???h?璀?｛?夸z罐?+€?zf＂?????i?????_璁?:+v??撸?