On Tuesday 12 March 2013 07:58 PM, Benoit Cousson wrote: > On 03/12/2013 06:07 AM, Santosh Shilimkar wrote: >> On Tuesday 12 March 2013 04:35 AM, Nishanth Menon wrote: >>> commit 5553f9e (cpufreq: instantiate cpufreq-cpu0 as a platform_driver) >>> now forces platform device to be registered for allowing cpufreq-cpu0 >>> to be used by SoCs. example: drivers/cpufreq/highbank-cpufreq.c >>> >>> However, for SoCs that wish to link up using device tree, instead >>> of platform device, provide compatibility string match: >>> compatible = "cpufreq,cpu0"; > > You cannot add a non-HW relative binding... DT is supposed to represent > the pure HW. > AFAIK, cpufreq has nothing to do with the HW definition. > You are right. >>> >>> Cc: "Rafael J. Wysocki" <rjw@xxxxxxx> >>> Cc: Santosh Shilimkar <santosh.shilimkar@xxxxxx> >>> Cc: Shawn Guo <shawn.guo@xxxxxxxxxx> >>> Cc: linux-kernel@xxxxxxxxxxxxxxx >>> Cc: cpufreq@xxxxxxxxxxxxxxx >>> Cc: linux-pm@xxxxxxxxxxxxxxx >>> Cc: linux-omap@xxxxxxxxxxxxxxx >>> >>> Signed-off-by: Nishanth Menon <nm@xxxxxx> >>> --- >>> .../devicetree/bindings/cpufreq/cpufreq-cpu0.txt | 3 +++ >>> drivers/cpufreq/cpufreq-cpu0.c | 6 ++++++ >>> 2 files changed, 9 insertions(+) >>> >> Looks fine to me. CC'ing dt list in case some one has >> comments on binding updates. >> >> Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx> > > Not-Acked-by-me. > I obviously missed the point while acking the patch. Regards, santosh -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
